Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Reloading #61

Closed
dustalov opened this issue Apr 9, 2012 · 1 comment
Closed

Code Reloading #61

dustalov opened this issue Apr 9, 2012 · 1 comment

Comments

@dustalov
Copy link

dustalov commented Apr 9, 2012

A small code review led me to one interesting feature of the Puma control server: the /reload action.

When I've set up Puma with the following command:

% bundle exec puma --control 'tcp://127.0.0.1:1337' --control-token 'foo'
Puma 1.1.1 starting...
* Min threads: 0, max threads: 16
* Listening on tcp://0.0.0.0:9292
* Starting status server on tcp://127.0.0.1:1337
Use Ctrl-C to stop

and executed the following command:

% curl 'http://127.0.0.1:1337/restart?token=foo'

I got no output from curl among with the following strange output from Puma process:

* Restarting...
Puma 1.1.1 starting...
* Min threads: 0, max threads: 16
* Listening on tcp://0.0.0.0:9292
* Starting status server on tcp://127.0.0.1:1337
Address already in use - bind(2)

The Puma process was terminated. Is this bug or feature?

@dustalov
Copy link
Author

dustalov commented Apr 9, 2012

If it is important to investigation, I'm running Ruby 1.9.3 (with falcon patch) under Fedora 16 (x86_64).

% ruby -v
ruby 1.9.3p125 (2012-02-16 revision 34643) [x86_64-linux]
% uname -a
Linux tazik 3.3.1-3.fc16.x86_64 #1 SMP Wed Apr 4 18:08:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants