Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puma missing query string #937

Closed
huangxiangdan opened this issue Mar 29, 2016 · 4 comments
Closed

puma missing query string #937

huangxiangdan opened this issue Mar 29, 2016 · 4 comments

Comments

@huangxiangdan
Copy link

Hi, all

I'm using puma 3.2 as my Rails webserver. When I make a http get request with query string like this,

GET http://192.168.1.96:3000/api/v1/matches/test?1=1 HTTP/1.1  
Accept: text/event-stream
Authorization: Token  token=QsG8IZ77ng0e9PJXgKyEzniRe4lCbK7yeeB1B+9MKnaG6Aa08c7zDZGAH19XbdJICJgHcZr9YMeGLi+3dCkWaA==, imei=867575025069603   
Host: 192.168.1.96   
Origin: http://192.168.1.96   
Cache-Control: no-cache

Puma is missing the query string "1=1", like

Started GET "/api/v1/matches/test" for 192.168.1.45 at 2016-03-29 11:30:12 +0800

When I change my webserver back to WEBrick, It workes fine.

Started GET "/api/v1/matches/test?1=1" for 192.168.1.45 at 2016-03-29 11:32:12 +0800

I think it's a bug of puma. Please check it.
@evanphx
Copy link
Member

evanphx commented Mar 29, 2016

Are you using puma as a proxy server? Why are you including a URL in the path?

@huangxiangdan
Copy link
Author

No, I'm not using puma as a proxy server. I run it direct on command "rails server", and then I request from my android app.

Some android lib behave like this, using absolute url in the path. I'm using eventsource. And I checked HTTP 1.1 protocol , using absolute url is fine.

@evanphx
Copy link
Member

evanphx commented Mar 30, 2016

@huangxiangdan Ah ok. Just curious. Can you verify for me if the query params are missing in the actual code or is it just the log output?

@huangxiangdan
Copy link
Author

The query params are missing in the actual code.

@evanphx evanphx closed this as completed in d672932 Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanphx @huangxiangdan