Replaced `org-export-solidify-link-text'. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 11, 2015 15:03
*Environment*
Emacs Version: “24.4.1”
Org-Mode Version: “8.3.1”
Org2Blog/WP Version: “0.5”
Timestamp: “Fri Sep 11 15:02:09 2015”
Steps:
• Run Emacs from Homebrew
• Load Org-Mode from git
• Load Org2Blog from git
• Configure [the blog]
• Log in
• Call `org2blog/wp-post-buffer'
Behavior
• Expected
• Post posted
• Actual
• Got error
format: Symbol’s function definition is void:
org-export-solidify-link-text
Research:
• [ox-twbs]
• [ox-reveal]
• Function [was removed]
Solution:
• [Use `org-export-get-reference' instead].
Removed function `org-export-solidify-link-text' This
function, being non-bijective, introduced bug in internal
references. Use `org-export-get-reference' instead.
Test:
• Performed steps and article posted.
[the blog]
https://github.com/grettke/help/blob/master/.emacs.el#L1882-#L1888
[ox-twbs] marsmining/ox-twbs#7
[ox-reveal] yjwen/org-reveal#127
[was removed]
http://orgmode.org/w/?p=org-mode.git;a=commit;h=68eb1d0ab0c153a1403d3c80fb3049ddc57aa26c
[Use `org-export-get-reference' instead]
http://orgmode.org/w/?p=org-mode.git;a=blobdiff;f=lisp/ox.el;h=d6dcc826290927f56e211328447c9e8d507797aa;hp=a6afc304af79444236905e12195fba0e13fdc831;hb=68eb1d0ab0c153a1403d3c80fb3049ddc57aa26c;hpb=459033265295723cbfb0fccb3577acbfdc9d0285
Emacs re-indented the document. There are no other changes.
punchagan
added a commit
that referenced
this pull request
Sep 12, 2015
Replaced `org-export-solidify-link-text'.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Emacs Version: “24.4.1”
Org-Mode Version: “8.3.1”
Org2Blog/WP Version: “0.5”
Timestamp: “Fri Sep 11 15:02:09 2015”
Steps:
• Run Emacs from Homebrew
• Load Org-Mode from git
• Load Org2Blog from git
• Configure [the blog]
• Log in
• Call `org2blog/wp-post-buffer'
Behavior
• Expected
• Post posted
• Actual
• Got error
format: Symbol’s function definition is void:
org-export-solidify-link-text
Research:
• [ox-twbs]
• [ox-reveal]
• Function [was removed]
Solution:
• [Use
org-export-get-reference' instead]. Removed functionorg-export-solidify-link-text' Thisfunction, being non-bijective, introduced bug in internal
references. Use `org-export-get-reference' instead.
Test:
• Performed steps and article posted.
[the blog]
https://github.com/grettke/help/blob/master/.emacs.el#L1882-#L1888
[ox-twbs] marsmining/ox-twbs#7
[ox-reveal] yjwen/org-reveal#127
[was removed]
http://orgmode.org/w/?p=org-mode.git;a=commit;h=68eb1d0ab0c153a1403d3c80fb3049ddc57aa26c
[Use `org-export-get-reference' instead]
http://orgmode.org/w/?p=org-mode.git;a=blobdiff;f=lisp/ox.el;h=d6dcc826290927f56e211328447c9e8d507797aa;hp=a6afc304af79444236905e12195fba0e13fdc831;hb=68eb1d0ab0c153a1403d3c80fb3049ddc57aa26c;hpb=459033265295723cbfb0fccb3577acbfdc9d0285