Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator doesn't write to save file until the Emulator is closed. #20

Closed
Zerowalker opened this issue May 18, 2016 · 3 comments
Closed

Comments

@Zerowalker
Copy link

I noticed the hard way that the Emulator doesn't write the save file of the game until the Emulator is closed.

As my Emulator crashed and i had played A Lot (even restarting the Emulator and continuing on the save file) the data from that time was lost.

So the save file i had when i started up the Emulator next time was from when i last closed it down.

This should be changed, there is no reason to buffer the save file, cause then this kind of things can happen.

Of course it's a rare occurrence, but as it can be prevented it should:)

Thanks!

@punesemu
Copy link
Owner

I don't buffer the save file, I write it every time. Ok, I think I understand the problem, imagine that you are using the windows version of the emulator. In windows it is always worth use a fflush() after the fwrite() to force the write of file. Thanks for the report.

Edit: fixed in personal WIP.

@Zerowalker
Copy link
Author

Yes using windows version.

Thanks:)!

@jcdenton2k
Copy link

As of the v1.01 WIP build of Nov 2016 this is confirmed working right now and can be enabled via a UI option in the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants