infringement

[netpipe]

im not sure but the picture of the nes controller in the controller config should have a different picture it might be infringing on the patent. remove the words nintendo and start and select and it should be ok.

[netpipe]

https://ibin.co/4HgZECJRsIYY

[netpipe]

also one should probably give instructions how to modify a 3rd party controller such as the usb ones on ebay by cutting out the start / select part of the sticker, and by reversing the button order of the start and select buttons for controller config(maybe a predefined controller config for legal 3rd party clones).

[netpipe]

also there is a bug with the usb clone controllers that dont permit up/down left right at the same time without it sticking to a direction. pulls to the right or left and gets stuck like that.

[ghost]

@punesemu

I made some changes to the Nes_controller.svg but I had to save it as .png
This solves the infrigement problems @tecan addressed with removal of the Nintendo logo and I also replaced the fonts to Segoe UI.

[punesemu]

Hi RokkumanX, can you send me the SVG? I need the image in that format.

[ghost]

Here you go @punesemu

Nes_controller.zip

Looks really great!

[punesemu]

Sorry but your svg is empty. I tried to open it with gimp and with another image viewer and the result was identical.

[ghost]

@punesemu

I installed Inkscape and created this:

Nes_controller.zip

Looks good and opens in Gimp fine!

[ghost]

I created a pull request and the result sure looks good to me:
https://github.com/RokkumanX/puNES/blob/patch-1/src/gui/designer/pics/Nes_controller.svg

It's ready to merge at any time!

[netpipe]

you need to remove the red lettering to another color or change the order of the start and select button. it should be done in code/gameplay too. it was part of the patent stipulation they described what it looked like.

[ghost]

I will fix this as soon as I get home @tecan
I have the right softare now so it's easy.

Thanks for the headup!

[ghost]

Is this good enough @tecan
https://github.com/RokkumanX/puNES/blob/patch-1/src/gui/designer/pics/Nes_controller.svg

What do you think @punesemu ?

[punesemu]

Dark blue on dark gray is not very readable. A light color would be better.

[ghost]

@punesemu

https://github.com/RokkumanX/puNES/blob/patch-1/src/gui/designer/pics/Nes_controller.svg

EDIT:

The design on this NES controller is pretty unique now:

1. Altered background color to a lighter grey
2. Changed font to Segoe UI and font color to cyan
3. Changed color of the B & A buttons to plain blue
4. The puNES logo is used instead of the Nintendo logo

Infringement issues = 0

The cyan/blue colors are an homage to the blue bomber!

[ghost]

So what's happening guys? The only thing I have heard so far from you is things that needs to be changed and what not.

It literally feels like talking to yourself at this point.

Should I take the silence that you are so unhappy with the result that you simply won't bother answering or should I take the silence and interpret it for something good?

I know real life can be busy at times, but 5 days without any answer or feedback? Even at work I wouldn't even treat my enemies like this.

If I don't hear from you I can't know if the work I've done is good or bad and if I don't know that well then I can't do much more than talking to myself.

At least I tried and made my part fixing this....

[punesemu]

First of all, I thank you for your help and for your work, I like SVG and I will use it. As for the lack of feedback these days, it is due solely to the lack of time. As I wrote 5 days ago in another comment, during the week due to a new job I have no free time to devote to the emulator and unfortunately not even to the community, I can do it only during the weekend and it is only for this reason that I answer you only today.

[ghost]

That's all I wanted to hear man, thanks a lot!

[netpipe]

looks good to me thanks for working on PUNES its the best looking NES Emu i've used. the only other thing that could be done is changing the order(swapping) of start and select button text being the font is blue now its probably good.

[ghost]

I don't think the position of Select and Start causes any infringement problems, a lot of different controllers (non-Nintendo) use the same layout for Select and Start and I never heard Nintendo or any other company complained about it.

Swapping it around would only confuse end-users, no other controller that I have seen or laid eyes on have Start and then Select.

In every gamers mind it's Select and Start, it's not trademarked in any way.

However the old Nes_controller.svg did indeed cause infringement issues using the same colors and logo as the original controller.

The end result now is different.

[ghost]

This issue can now be closed, it's been resolved since f326c4c