Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Jersey suspendables for request and response filters #71

Merged
merged 3 commits into from Sep 12, 2016

Conversation

victornoel
Copy link
Contributor

As discussed on the mailing-list, here is a PR to add some suspendables in Jersey.

I put all the commits I had a need for (in particular some ignore for Eclipse) but I can remove whichever you want and merge the last two if you prefer :)

Also, in Eclipse, I had to add a compile dependency for quasar-core (in the global dependencies scope), because Eclipse wouldn't add it from the quasar configuration's one otherwise. I didn't commit that, but if you know of a clean way to fix that problem, I'm interested :)

@victornoel
Copy link
Contributor Author

victornoel commented Aug 31, 2016

Also the imports were all reordered by Eclipse, I can limit the differences to the strict minimum if you prefer :)

Add some tests to ensure the filters are called as desired.
@circlespainter
Copy link
Member

Thanks!

@victornoel
Copy link
Contributor Author

@circlespainter any reason why this was closed but not merged?

@circlespainter circlespainter merged commit 13758a4 into puniverse:master Sep 12, 2016
@circlespainter
Copy link
Member

Sorry my mistake, thanks for notifying.

@victornoel
Copy link
Contributor Author

@circlespainter thanks :)

@victornoel victornoel deleted the jersey-suspendables branch September 12, 2016 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants