-
Notifications
You must be signed in to change notification settings - Fork 631
Compress vagrant files with ZipArchive #42
Comments
Hi, To run puphpet locally you need to clone https://github.com/puphpet/vagrant-puppet-lamp and run |
Ok! =) It is a simple refactoring ;) |
I had originally chosen ZipArchive, but a few problems:
Looking back I probably could have gone another, more logical route before jumping to Can you tell me what problems you had with the compression? It should work perfectly on all VMs, that's the whole point. |
I also have a problem with ZipArchive. When I jumped onto this project I thought "man this has to be refactored to ZipArchive as soon as possible" after I have seen this exec call. Time has passed and I do not see the benefit using this PHP feature anymore. Besides like @jtreminio I do not understand your initial problem. Did you use vagrant-puppet-lamp for provisioning your dev box or did you configure your dev box with the help of puPHPet and perhaps missed to add the zip package? |
OK, I explain my problem. =) You can look my commit, in my fork, with this changes to resolve the warnings: tonicospinelli@badb6b2 Could you understand now? =) |
Gotcha. The thing is, if you want to actually run a local copy of puphpet.com, you should do the following:
I realize the documentation isn't very good at all right now, but we've been pumping out so much new stuff it was hard to find time. I will make sure to find time soon. |
Hi, After juggling with the decision, I've decided not to merge this in. Requiring devs to use vagrant-puppet-lamp for developing puphpet gives us the freedom to use any tool and any version that we want, without worrying about compatibility issues. Please don't stop submitting PRs are you create something new and awesome, though! Thanks, |
Ok my friend! =) I will do new PRs when I find new improvements or features. Thanks, |
I did create a virtual machine with puPHPet, and I was testing my fork with new improvements.
After VM was up, I had problems with data compression and I changed the compression to \ZipArchive.
I did some tests with this improvement and it's working good.
You can look in my fork:
tonicospinelli@badb6b2
If you agree, I do a PR with my changes.
The text was updated successfully, but these errors were encountered: