Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Create tests for different configurations of Vagrantfile/manifests #45

Closed
jtreminio opened this issue Jun 2, 2013 · 2 comments
Closed
Assignees

Comments

@jtreminio
Copy link
Member

Need to more completely cover the end result. Not the vagrant-puppet-lamp code, but what is generated by puphpet directly.

Will need refactor Puphpet\Controller\Front::createAction() and separate out the twig stuff from the file generation stuff from the download file stuff.

Will need to more strictly define what values are valid for each input field from website, and create random data from valid values.

Then we can run multiple tests through puppet-lint to see if our stuff builds.

@ghost ghost assigned jtreminio Jun 2, 2013
@staabm
Copy link
Contributor

staabm commented Jun 3, 2013

@frastel
Copy link
Contributor

frastel commented Jun 3, 2013

I currently think about compiling the complete manifest from fragments. This could be done like the file configurator mechanism I added in the master recently (or even better event based). Means some configurator can register on manifest manipulation (webserver configurator, database configurator, php configurator etc.). When the configuration matches for the configurator it will execute otherwise it will idle (nginx configurator adds only something to the manifest when webserver == 'nginx').
In this way we could create really simple tests for each partial + configurator and drop the complex and huge manifest test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants