Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of puppetdb v4 #34

Closed
wants to merge 2 commits into from
Closed

Conversation

russell
Copy link

@russell russell commented Jun 20, 2014

Hi,

This commit is probably incomplete, i haven't had a chance to check all the existing v3 APIs that will be exposed by the v4 subclass. But I thought it might be a good idea to get some feedback about what i have done so far. Would this be something that you would be willing to merge upstream?

Cheers,
Russell

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b8a82a1 on NeCTAR-RC:master into * on nedap:master*.

@daenney
Copy link
Member

daenney commented Jun 20, 2014

I think we're going to run into a few issues here because of what's changed on v4, namely the environments support which we need to account for in the objects.

@russell
Copy link
Author

russell commented Jun 21, 2014

Ah, i see what you are talking about.... the __query_scope variable? I can extend the patch to cover that.

Do you think we should try and get some more integration style tests with some example json parsing into objects from each of the different versions?

@daenney
Copy link
Member

daenney commented Jun 21, 2014

Yes, that would be a good step forward. I'm considering using betamax to record from a live session against PuppetDB and then simply replay those whenever we run the tests.

@hggh
Copy link
Contributor

hggh commented Apr 19, 2015

any news on pypuppetdb support v4?

@corey-hammerton
Copy link
Contributor

Any updates?

@daenney
Copy link
Member

daenney commented Jul 22, 2015

This would need quite a bit of rework, and some other parts of PuppetDB too, in light of the 3.x release of PuppetDB. I don't think it's worth the effort supporting two "versions" of the v4 API. As such we're probably better off abandoning this and keeping 2.x support up to and including v3 and releasing a new major version of pypuppetdb that drops the legacy baggage and talks to PuppetDB 3.x over v4.

@daenney daenney closed this Jul 22, 2015
@corey-hammerton
Copy link
Contributor

I will be able to work on this as a side project of mine. I will create a fork of this repository and work on it there while testing against a PuppetDB 3.x instance on a test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants