Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to run google_search_features.js #18

Closed
osmestad opened this issue Nov 7, 2018 · 3 comments
Closed

Failing to run google_search_features.js #18

osmestad opened this issue Nov 7, 2018 · 3 comments

Comments

@osmestad
Copy link

osmestad commented Nov 7, 2018

Very cool usages!

Unfortunately I'm having problems running the Google Search example, my output is:

oyvinds-mac:puppeteer-examples osmestad$ node google_search_features.js
Trace started.
Navigating to https://www.chromestatus.com/features
Waiting for page to be idle...
Trace complete.
(node:2259) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'pid' of undefined
    at trace.traceEvents.filter.e (/Users/osmestad/Code/puppeteer-examples/google_search_features.js:195:38)
    at Array.filter (<anonymous>)
    at collectFeatureTraceEvents (/Users/osmestad/Code/puppeteer-examples/google_search_features.js:193:36)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:2259) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2259) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I'v tried with Node v8.12.0 and v10.13.0 any idea what might be causing this?
(lazyimages_without_scroll_events.js worked for me)

@osmestad
Copy link
Author

osmestad commented Nov 8, 2018

If I revert Puppeteer to 1.7.0 it works :-) so I assume it is something that has changed between 1.7 and 1.8?

@RandomDude123
Copy link

I couldn't fix it by downgrading to 1.7.0 - still get the error from above

@mkamakura
Copy link
Contributor

I also tried it. It works with v1.7.0 but does not work with v1.8.0.
It seems that TracingStartedInPage can not be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants