Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: npm_package_config_puppeteer_skip_download not working #10757

Closed
2 tasks
renandecarlo opened this issue Aug 18, 2023 · 3 comments
Closed
2 tasks

[Bug]: npm_package_config_puppeteer_skip_download not working #10757

renandecarlo opened this issue Aug 18, 2023 · 3 comments

Comments

@renandecarlo
Copy link

Minimal, reproducible example

// Add this to project's package.json
"config": {
  "puppeteer_skip_download": true
}

Error string

no error

Bug behavior

  • Flaky
  • PDF

Background

The "puppeteer_skip_download" variable is not working when using it in the project's package.json config.
Using the variable in .npmrc works though.

Expectation

I expect it to avoid downloading a chrome installation.

Reality

It does download it even when using the variable in project's package.json config

Puppeteer configuration file (if used)

No response

Puppeteer version

21.1.0

Node version

18.17.1

Package manager

npm

Package manager version

9.8.1

Operating system

Windows

@github-actions
Copy link

The issue has been labeled as confirmed by the automatic analyser.
Someone from the Puppeteer team will take a look soon!


Analyzer run

@xfournet
Copy link

xfournet commented Oct 5, 2023

The correct configuration in package.json is

  "puppeteer": {
    "skipDownload": true
  }

@OrKoN
Copy link
Collaborator

OrKoN commented Mar 29, 2024

It looks like in this is caused by change in npm? https://github.com/npm/rfcs/blob/main/implemented/0021-reduce-lifecycle-script-environment.md I confirmed that npm does not set expected environment variables in this case any longer. We recommend using Puppeteer configuration files https://pptr.dev/guides/configuration

@OrKoN OrKoN closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants