New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement typed events #10889
feat: implement typed events #10889
Conversation
2c98eeb
to
1787475
Compare
0e88ac0
to
8660957
Compare
4b5bd0a
to
d990639
Compare
Would it be considered a breaking change? I assume if someone used string literals for event names before it might not compile after this change. |
Could you add a description about what has specifically changed with a basic before and after example? (I assume |
There are no breaking changes, see tests for example.
Done. |
ee9dc8d
to
1dedd10
Compare
so what is the user facing change then? should it be prefixed as |
Users now get the correct typing when they try to add a listener which required manual typing previously. We could label it as a |
1dedd10
to
02ac4f8
Compare
I am not sure, maybe feat is good. Btw, GitHub UI really struggles to render the diffs in readable manner: I guess it's lazy-loaded so you cannot actually jump to a specific file without scrolling for a while first. |
02ac4f8
to
46cb6ac
Compare
77001c2
to
1a34f0e
Compare
1a34f0e
to
d0d3b30
Compare
1eddb9d
to
069ddb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + please answer the two question like comments and look at nits, and wait for all test to pass.
6c828e4
to
6331837
Compare
6331837
to
5577f20
Compare
This PR implements typings for emitted events in all event emitters.