Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Browser.connected #10927

Merged
merged 1 commit into from Sep 18, 2023
Merged

feat: implement Browser.connected #10927

merged 1 commit into from Sep 18, 2023

Conversation

jrandolf
Copy link
Contributor

Browser.isConnected is being deprecated in favor of Browser.connected which coincides with other disposal APIs such as disposed.

Base automatically changed from jrandolf/docs to main September 18, 2023 09:05
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Let's merge the doc changes and rebase this PR as some changes are not from this PR.

`Browser.isConnected` is being deprecated in favor of `Browser.connected`.
@jrandolf jrandolf merged commit a4345a4 into main Sep 18, 2023
28 of 30 checks passed
@jrandolf jrandolf deleted the jrandolf/connected branch September 18, 2023 09:14
@release-please release-please bot mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants