fix: handle missing detach events for restored bfcache targets #10967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
commented
Sep 20, 2023
| targetInfo.type === 'service_worker' && | ||
| this.#connection.isAutoAttached(targetInfo.targetId) | ||
| ) { | ||
| if (targetInfo.type === 'service_worker') { |
There was a problem hiding this comment.
unrelated change: this condition is redundant because of the check on line 351 (improved for readability)
OrKoN
force-pushed
the
orkon/fix-bfcache-worker
branch
from
ff66720
to
11ab875
Compare
OrKoN
force-pushed
the
orkon/fix-bfcache-worker
branch
2 times, most recently
from
a23c051
to
bb8fdca
Compare
Lightning00Blade
approved these changes
Sep 21, 2023
OrKoN
force-pushed
the
orkon/fix-bfcache-worker
branch
from
bb8fdca
to
06c939e
Compare
This was referenced Sep 21, 2023
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we navigate from a page with a worker in an OOPIF to another, we don't get a target detached event for the worker. The session and the target, therefore, continues to be registered as "attached" by Puppeteer. This leads to an issue when on going back to the same page the worker target is double attached. This behaviour is probably caused by the fact that the page is put into a bfcache instead of being actually destroyed. Probably, the correct behaviour from the CDP side would be to keep the client attached to the cached session instead of creating new sessions. Currently, this is not the case so I filed https://crbug.com/1485193.
Closes #10946 #10966