chore: implement BiDi sendCharacter #11000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/send-character
branch
from
dfb0aab
to
639a4cd
Compare
OrKoN
reviewed
Sep 22, 2023
jrandolf
force-pushed
the
jrandolf/send-character
branch
3 times, most recently
from
a0388fe
to
722380e
Compare
Lightning00Blade
approved these changes
Sep 22, 2023
OrKoN
approved these changes
Sep 22, 2023
jrandolf
force-pushed
the
jrandolf/send-character
branch
from
722380e
to
0435645
Compare
jrandolf
force-pushed
the
jrandolf/send-character
branch
from
0435645
to
8cea469
Compare
OrKoN
reviewed
Sep 22, 2023
| .evaluateHandle(() => { | ||
| let frame: HTMLIFrameElement | undefined; | ||
| let win: Window | null = window; | ||
| while (win?.document.activeElement instanceof HTMLIFrameElement) { |
There was a problem hiding this comment.
this does not work for OOPIFs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.