Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid structuredClone for Node 16 #11006

Merged
merged 1 commit into from Sep 22, 2023
Merged

fix: avoid structuredClone for Node 16 #11006

merged 1 commit into from Sep 22, 2023

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Sep 22, 2023

Although we drop Node 16 support soon, we should keep the code compatible with Node 16 due to semver.

Closes #11004

Altough we drop Node 16 support soon, we should keep the
code compatible with Node 16.
@OrKoN OrKoN requested a review from jrandolf September 22, 2023 18:48
@OrKoN
Copy link
Collaborator Author

OrKoN commented Sep 22, 2023

@jrandolf I believe Chromium might still be on Node 16. Let's publish this as a patch release.

@jrandolf jrandolf merged commit 25eca9a into main Sep 22, 2023
33 of 34 checks passed
@jrandolf jrandolf deleted the orkon/structuredClone branch September 22, 2023 20:37
@release-please release-please bot mentioned this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error with missing structuredClone API in Node 16 when doing a screenshot
2 participants