Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshot tests are flaky/failing after M120 roll #11502

Closed
OrKoN opened this issue Dec 6, 2023 · 2 comments
Closed

Screenshot tests are flaky/failing after M120 roll #11502

OrKoN opened this issue Dec 6, 2023 · 2 comments
Assignees
@jrandolf
Labels
bug confirmed flaky test

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Dec 6, 2023

See for the tests that have been affected: https://github.com/puppeteer/puppeteer/pull/11501/files

@jrandolf could you please take a look as well as at the user reported bugs?
@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 6, 2023

"[emulation.spec] Emulation Page.emulateVisionDeficiency should work" is also flaky due to the screenshots.

@jrandolf
Copy link
Contributor

Bisected to https://chromium.googlesource.com/chromium/src/+log/b8b95f5715b4bd2348e537b740048e4b6aa281b1..8026f46b0e73174f33834a26748107d1089a83bf

Doesn't look correct though; local builds work fine. Still investigating.

@jrandolf jrandolf mentioned this issue Dec 13, 2023
Merged
@OrKoN OrKoN closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrandolf jrandolf

Labels
bug confirmed flaky test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OrKoN @jrandolf