Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Rename incognito browser contexts #11686

Closed
OrKoN opened this issue Jan 15, 2024 · 3 comments
Closed

[Feature]: Rename incognito browser contexts #11686

OrKoN opened this issue Jan 15, 2024 · 3 comments
Labels
confirmed feature

Comments

@OrKoN
Copy link
Collaborator

OrKoN commented Jan 15, 2024

Feature description

We need to remove mentions of incognito because it makes little sense in a cross-browser setting.

We have options how to name it:

  1. keep it named BrowserContext and only remove incognito in few APIs.
  2. rename everything to Context
  3. rename everything to UserContext to align with WebDriver BiDi
@jrandolf
Copy link
Contributor

I agree with (3), to better align with ongoing efforts and distinguish it from the old API.

@Lightning00Blade WDYT?

@Lightning00Blade
Copy link
Collaborator

I agree (3) sounds like the best options considering cross-browser.

@OrKoN OrKoN mentioned this issue Feb 5, 2024
Merged
This was referenced Feb 21, 2024
Closed
Merged
@Lightning00Blade
Copy link
Collaborator

Closing as completed by the by the linked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OrKoN @Lightning00Blade @jrandolf