feat: add experimental browser.debugInfo #11748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/getPendingProtocolErrors
branch
2 times, most recently
from
3dc8604
to
296d8c4
Compare
OrKoN
changed the title
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/getPendingProtocolErrors
branch
3 times, most recently
from
3a0f449
to
1c43d44
Compare
Lightning00Blade
approved these changes
Jan 25, 2024
| * @internal | ||
| */ | ||
| getPendingProtocolErrors(): Error[] { | ||
| const result: Error[] = []; |
There was a problem hiding this comment.
Nit: Simplify to a map?
OrKoN
force-pushed
the
orkon/getPendingProtocolErrors
branch
2 times, most recently
from
3394d60
to
7317010
Compare
jrandolf
reviewed
Jan 25, 2024
This is an experimental method that would provide debugging information to help debug issues with Puppeteer. Currently, it only provides the stacktraces for pending protocol calls.
OrKoN
force-pushed
the
orkon/getPendingProtocolErrors
branch
from
7317010
to
d3a2646
Compare
Merged
|
We miss adding this to the website, can you file an issue or PR for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental method that provides debugging information to help debug issues with Puppeteer.
Currently, it only provides the stacktraces for pending protocol calls.
Note: the test failure is unrelated and tracked in #11749 It's revealed by the change in sharding caused by introduction of a new spec.