fix: set viewport for element screenshots #11772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/fix-element-screenshot
branch
from
165193b
to
539fab4
Compare
OrKoN
reviewed
Jan 29, 2024
jrandolf
force-pushed
the
jrandolf/fix-element-screenshot
branch
from
539fab4
to
6e64a35
Compare
|
As discussed offline, we will merge this and create a breaking change in the next release. |
jrandolf
force-pushed
the
jrandolf/fix-element-screenshot
branch
from
6e64a35
to
2f181fd
Compare
OrKoN
approved these changes
Jan 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the element is larger than the viewport but within a scrollable element, the element will cut off (
captureBeyondViewportwill not help here). To alleviate this problem, we need to adjust the viewport to (hopefully) enlarge the scrollable element to capture the inner element.Fixed: 11597