New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 space indentation across project #19
Comments
The 2-space indentation sounds fine for me - would you mind sending a pr?
The current eslintrc.js is a copy of chrome devtools eslintrc (with the only difference of 4 spaces, for historic reasons). I'm not really familiar with the Google's style guide. I think it's fine to adopt it if there's a tool which enforces it to full extend - so that we don't end up with a code written in a mixture of devtool's and google styles. |
Sure. I can send a PR with the update. |
This patch: - reformats codebase to use 2-spaces instead of 4. This will align the project with other codebases (e.g. DevTools and Lighthouse) - enables eslint indentation checking References #19
This patch: - reformats codebase to use 2-spaces instead of 4. This will align the project with other codebases (e.g. DevTools and Lighthouse) - enables eslint indentation checking References #19
This patch: - reformats codebase to use 2-spaces instead of 4. This will align the project with other codebases (e.g. DevTools and Lighthouse) - enables eslint indentation checking References #19
@aslushnikov
Mind if we switch to 2-space identation? That's more common in JS projects these days and we tend to stick with Google's style guide in the GoogleChrome org.
We can extend the google style guide in eslintrc.js to enforce it :)
The text was updated successfully, but these errors were encountered: