Add type checking to CDPSession.send

[FiloSottile]

devtools-protocol provides type definitions for the remote protocol commands.

GoogleChrome/lighthouse#4914 added support for type checking in their equivalent of CDPSession.send. It would be very useful to have the same for CDPSession.send.

[JoelEinbinder]

We have type checking for CDPSession.send in Puppeteer! Check out https://github.com/GoogleChrome/puppeteer/blob/master/utils/protocol-types-generator/index.js.

We don't maintain the @types/puppeteer project, but you can find them here: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/puppeteer.

[FiloSottile]

Hmm, interesting. I don't see them applied in VSCode with @types/puppeteer 1.3.4.

Should I move this to DefinitelyTyped?

[aslushnikov]

@FiloSottile looks like DefinitelyTyped just lacking some types; whoever wants to contribute them there, feel free to generate type descriptions using our generator that Joel referred to.