Modified request headers don't appear in response.request().headers()

[tolmasky]

I'm doing something relatively simple in the request interception:

const headers = request.headers();
const modifiedHeaders = { ...headers, "x-new-header": "true" };

request.continue({ headers: modifiedHeaders });

However, later, when I receive the callback for the response, this header is missing from the associated request:

response.request().headers()["x-new-header"] !== "true";

I am trying to mark the request as modified so that later in the response I know this was one of my intercepted requests.

[aslushnikov]

However, later, when I receive the callback for the response, this header is missing from the associated request

@tolmasky We don't update headers in a requests. It looks like the workaround below would suite you well, so I'd keep it this way.

I am trying to mark the request as modified so that later in the response I know this was one of my intercepted requests.

Since request and response.request are exactly the same objects, you can just mark requests with a symbol:

const wasModified = Symbol('requestWasModified');

// ...

request.continue({headers: modifiedHeaders});
request[wasModified] = true;

// ....

response.request()[wasModified] === true;

Will it work for you?

[tolmasky]

Hi @aslushnikov , the workaround worked and I am currently using it in my code. Thank you very much for the suggestion.

That being said, I do believe that the correct behavior here is that the request object should be updated, as the request reported by response.request() is stale, and might be significantly diverged from the request that actually ended up being sent. If you have two libraries that don't know about each other (as opposed to my example where I control both ends), this could lead to more complex and difficult to debug incorrect behavior.