Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frames api #4

Closed
aslushnikov opened this issue Jun 14, 2017 · 0 comments
Closed

Add frames api #4

aslushnikov opened this issue Jun 14, 2017 · 0 comments
Assignees
@aslushnikov

Comments

@aslushnikov
Copy link
Contributor

There should be a frames inspection API with an ability to evaluate code in frame
@aslushnikov aslushnikov mentioned this issue Jun 14, 2017
Closed
aslushnikov added a commit that referenced this issue Jun 21, 2017
@aslushnikov
Implement FrameManager
b3b0c1a 
This patch implements FrameManager which is responsible for maintaining
the frame tree. FrameManager is quite basic: it sends FrameAttached,
FrameDetached and FrameNavigated events, and can report mainFrame and
all frames.

The next step would be moving certain Page API's to the Frame. For
example, such method as Page.evaluate, Page.navigate and others should
be available on Frame object as well.

References #4
pavelfeldman pushed a commit that referenced this issue Jun 21, 2017
@aslushnikov @pavelfeldman
Implement FrameManager
1759631 
This patch implements FrameManager which is responsible for maintaining
the frame tree. FrameManager is quite basic: it sends FrameAttached,
FrameDetached and FrameNavigated events, and can report mainFrame and
all frames.

The next step would be moving certain Page API's to the Frame. For
example, such method as Page.evaluate, Page.navigate and others should
be available on Frame object as well.

References #4
@aslushnikov aslushnikov added this to the Puppeteer: ready for dogfood milestone Jun 27, 2017
@aslushnikov aslushnikov self-assigned this Jun 27, 2017
aslushnikov added a commit that referenced this issue Jun 27, 2017
@aslushnikov
Implement Frame.evaluate
3d90ea3 
This patch implements Frame.evaluate method.

References #4.
@astefanutti astefanutti mentioned this issue Aug 16, 2017
Closed
19 tasks
@rlog rlog mentioned this issue Aug 19, 2017
Closed
@omarsafwany omarsafwany mentioned this issue Jun 30, 2018
Closed
aslushnikov pushed a commit that referenced this issue May 18, 2019
@semoal @aslushnikov
fix: Page.setContent working with unicode strings (#4433)
60249e0 
Fix `page.setContent` with unicode strings that exceeds the range of a 8-bit byte.

This patch implements decoding part of the [MDN's solution #4 for the "unicode problem"](https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#Solution_4_%E2%80%93_escaping_the_string_before_encoding_it).

Since we rely on node.js buffer to encode into base64, we don't have troubles with base64 encoding, so it is left as-is.

Fixes #4424
@vikimaf vikimaf mentioned this issue Oct 22, 2019
Closed
@atindra91 atindra91 mentioned this issue Jul 30, 2020
Closed
@scooleo scooleo mentioned this issue Nov 3, 2020
Merged
@hopepanwei hopepanwei mentioned this issue Jan 18, 2021
Closed
@meirtb meirtb mentioned this issue Apr 5, 2022
Closed
@binhphi109 binhphi109 mentioned this issue Nov 8, 2022
Closed
@jucallej jucallej mentioned this issue Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslushnikov