mocha-utils defaultBrowserOptions don't take values from mocha config into account

[whimboo]

When running the Puppeteer unit tests we currently have setup a timeout of 25s when connecting to Firefox. Sadly these values are not taking into account by mocha-utils.

As result some of the tests in browser.spec.ts are failing because these depend on a non set custom timeout value from the config.

@mathiasbynens or @jackfranklin is that something you could fix? I would kinda appreciate that. I don't see a reason why the default config values shouldn't be used here. Thanks!

[stale]

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

[whimboo]

Not sure if this issue is still valid or not. The location of both files have been changed and I cannot see where the default settings from .mocharc.cjs are actually used. @OrKoN maybe you have a pointer or idea?

[OrKoN]

There is .mocharc.cjs and test/src/mocha-utils.ts now. Could you see if this still reproduces? I have been running Firefox tests for refactoring recently and have not noticed anything unusual.

[whimboo]

I actually miss the connection between defined constants in the .mocharc.cjs file and where these are used? Eg. for the timeout of 25s I still cannot find a line of code where it is used for the browser startup. Could you maybe point me to that?

[OrKoN]

@whimboo I believe the file is imported by mocha via yargs package directly and the value of timeout because an option for the Mocha constructor.

[OrKoN]

i.e., I don't think it's used for the browser setup in any way. It's only used to configure Mocha: a test would be considered timed out if it does not resolve within 25 sec.

[whimboo]

Ok, so maybe that was an issue with the former puppeteer-unit-tests.js mocha config file then. Given that quite some time has been passed since the issue was filed I cannot fully remember. And with a single config file now the problem might no longer exist. I would suggest to close the issue.