-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launcher): add new launcher option waitForInitialPage
#7105
Conversation
The existing behavior is expected to be unchanged as the value defaults to `true`. Adding such option would allow user to skip the initial wait.
Hi @jschfflr @OrKoN :) Sorry for bothering you. I picked your names by randomly checking a few recently merged PRs and looking for the reviewer's name. I understand that your team may have been rather busy working on other high priority tasks. However given that I'm rather new to contributing to this project, I'm yet unsure whether there's any other necessary step for me to do before expecting a review. Could you kindly suggest whether there is something else that I should have done, or shall I just keep waiting patiently? Thanks! :) |
Could we add a test for launching with this parameter and --no-startup-window to https://github.com/puppeteer/puppeteer/blob/main/test/launcher.spec.ts? |
…no-startup-window
To resolve the linter errors.
Sorry, I forgot to run the linter for the added test case, and it turns out that the long test subject line eventually triggers linter errors. I have pushed a new commit 11b6d12 to resolve that. |
The failure seems to be unrelated to this change. I think it's being looked at separately atm. |
starrify@ could you please rebase? |
Sorry I wasn't aware of the conflict.. I've just updated the branch to have the conflicts resolved. |
@starrify thanks! It looks fine. I have enabled auto-merge (and we squash all PRs by default) and hopefully it gets merged once CI is done (we had some flaky Firefox tests recently so it might fail again). |
The existing behavior is expected to be unchanged as the value defaults to
true
.Adding such option would allow user to skip the initial wait.
Relevant to #3630