-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more Android models to DeviceDescriptors #7210
Conversation
Adds device descriptions for: * Galaxy S8 * Galaxy S9+ * Galaxy Tab S4 * Pixel 3 * Pixel 4 These devices are regarded as worthy of targeting by [BrowserStack](https://www.browserstack.com/test-on-the-right-mobile-devices). Sources (both have identical data for these 5 devices): 1. https://github.com/aerokube/moon-deploy/blob/master/moon-local.yaml#L199 2. https://www.danhendricks.com/2018/04/adding-iphone-galaxy-chrome-mobile-emulated-devices/#heading_device_data
@mathiasbynens wdyt? |
I think the intention is to keep this in sync with the emulated devices in DevTools: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/panels/emulation/EmulatedDevices.ts;l=637-1368;drc=229a54f7ea0133738b1a6d395507dc80e4f18de8 I'm not opposed to landing this, but the way to do it would be to suggest the change as a DevTools patch before landing it here. Would you be up for that? |
@mathiasbynens, sounds good, I took a crack at it: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919612 |
03a4ca1
to
d4b17bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has now landed in DevTools.
Adds: Galaxy S8 Galaxy S9+ Galaxy Tab S4 Pixel 3 Pixel 4 These devices are regarded as worthy of targeting by https://www.browserstack.com/test-on-the-right-mobile-devices Sources (both have identical data for these 5 devices): 1. https://github.com/aerokube/moon-deploy/blob/master/moon-local.yaml#L199 2. https://www.danhendricks.com/2018/04/adding-iphone-galaxy-chrome-mobile-emulated-devices/#heading_device_data The same changes (structured differently) have been added to Playwright ( microsoft/playwright#6413 ). This PR was suggested by @mathiasbynens, see puppeteer/puppeteer#7210 Change-Id: I70db28b15b77fcdb82171a08ebd0b33aa0886621 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919612 Reviewed-by: Jan Scheffler <janscheffler@chromium.org> Reviewed-by: Changhao Han <changhaohan@chromium.org> Reviewed-by: Peter Müller <petermueller@chromium.org> Reviewed-by: Mraz Marian <mraz@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Thank you @jschfflr, for your help here and also in DevTools, very much appreciated! 🙏 |
@mrienstra Sure, happy to help! |
Adds device descriptions for:
These devices are regarded as worthy of targeting by BrowserStack.
Sources (both have identical data for these 5 devices):