-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo in InterceptResolutionStrategy #7780
Conversation
Hey @harshagrawal523! I noticed the same typo and was going to open a PR when I saw this one 😄 Can you sign the CLA and fix the commit message to follow the Conventional Commits standard so the tests can run? (e.g. |
Hi , actually this was my first PR , I just signed my CLA , what should I do next? |
@harshagrawal523 I think a maintainer has to approve the workflow, since it's your first PR. Let's wait and see 👀 Update: This typo has been also fixed in #7796. |
@@ -216,7 +216,7 @@ export class HTTPRequest { | |||
*/ | |||
private interceptResolution(): [InterceptResolutionStrategy, number?] { | |||
if (!this._allowInterception) return ['disabled']; | |||
if (this._interceptionHandled) return ['alreay-handled']; | |||
if (this._interceptionHandled) return ['already-handled']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The InterceptResolutionStrategy
must be updated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh , I will check it once
Fixed in #7813 |
What kind of change does this PR introduce?
There was a typo in line 210.
Did you add tests for your changes?
No
Summary
Does this PR introduce a breaking change?
No
Other information
None