refactor: remove unused QueuedEventGroup.promise #7830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, thanks, I didn't check if responseWaitingForExtraInfoPromise was actually used. |
OrKoN
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you add tests for your changes?
N/A
Summary
Referring back to discussion on https://github.com/puppeteer/puppeteer/pull/7826/files#diff-bc1ce23addce6e88bde0b9802379569654d1f1aa5ce76aa8883068604181ec31L7, I believe it is safe to remove all this.
NetworkManager.responseWaitingForExtraInfoPromise, while public, is not referenced in any code or docs.Does this PR introduce a breaking change?
Not sure. What is Puppeteer's policy on unpublished API changes?
NetworkManager.responseWaitingForExtraInfoPromiseis public but it is relatively new and I suspect was just a refactoring oversight. I see no purpose for it.