Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement request interception API #8

Closed
aslushnikov opened this issue Jun 14, 2017 · 2 comments
Closed

Implement request interception API #8

aslushnikov opened this issue Jun 14, 2017 · 2 comments
Assignees

Comments

@aslushnikov
Copy link
Contributor

The network request interception is a huge part of phantom.js capabilities which puppeteer was lacking. With the new addition to the devtools protocol, it is now possible to implement.

aslushnikov added a commit that referenced this issue Jun 15, 2017
This patch implements Request.setHeader() method to override
request headers.

References #8.
@aslushnikov aslushnikov added this to the v0.1 milestone Jun 27, 2017
@aslushnikov
Copy link
Contributor Author

the phantomshim tests are missing for this to be fixed

@aslushnikov aslushnikov self-assigned this Jun 28, 2017
@aslushnikov
Copy link
Contributor Author

The setRequestInterceptor seems to be working in Phantom_shim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant