Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use test runner for installation tests #9110

Merged
merged 1 commit into from
Oct 14, 2022
Merged

chore: use test runner for installation tests #9110

merged 1 commit into from
Oct 14, 2022

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented Oct 13, 2022

This PR adds a framework for building installation tests in Puppeteer. See existing tests for usage.

@jrandolf jrandolf requested a review from OrKoN October 13, 2022 16:28
@jrandolf jrandolf changed the title Tests 1 chore: use test runner for installation tests Oct 13, 2022
@jrandolf jrandolf changed the base branch from main to docs-1 October 13, 2022 16:31
@jrandolf jrandolf force-pushed the tests-1 branch 3 times, most recently from 4a675c0 to 8063acd Compare October 13, 2022 16:51
Base automatically changed from docs-1 to main October 13, 2022 16:55
@jrandolf jrandolf force-pushed the tests-1 branch 22 times, most recently from 4fa353c to 68c51d4 Compare October 14, 2022 00:16
@jrandolf jrandolf force-pushed the tests-1 branch 11 times, most recently from cdb117c to 706d409 Compare October 14, 2022 01:07
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % pnpm seems to be failing

@jrandolf jrandolf force-pushed the tests-1 branch 3 times, most recently from 019a0f7 to 23d857e Compare October 14, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants