feat: use configuration files #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
configuration
branch
11 times, most recently
from
30f8726
to
06b308e
Compare
jrandolf
force-pushed
the
configuration
branch
6 times, most recently
from
b4d7f38
to
69ae29c
Compare
OrKoN
reviewed
Oct 21, 2022
OrKoN
reviewed
Oct 21, 2022
OrKoN
reviewed
Oct 21, 2022
jrandolf
force-pushed
the
configuration
branch
5 times, most recently
from
79a0eb5
to
ea05c44
Compare
OrKoN
reviewed
Oct 21, 2022
OrKoN
reviewed
Oct 21, 2022
OrKoN
approved these changes
Oct 21, 2022
jrandolf
force-pushed
the
configuration
branch
from
ea05c44
to
c5cd53e
Compare
jrandolf
force-pushed
the
configuration
branch
from
c5cd53e
to
9053606
Compare
This was referenced Oct 21, 2022
Closed
Merged
Closed
Closed
This was referenced Nov 2, 2022
Closed
Closed
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configurations files to
puppeteer's methods for configuration. Under the hood,puppeteerrelies on https://www.npmjs.com/package/cosmiconfig which resolves several formats of configuration:puppeteerproperty in package.json.puppeteerrcfile in JSON or YAML format.puppeteerrc.json,.puppeteerrc.yaml,.puppeteerrc.yml,.puppeteerrc.js, or.puppeteerrc.cjsfilepuppeteer.config.jsorpuppeteer.config.cjsCommonJS module exporting an objectDocumentation will be added later.
Fixed: #9128