feat(page): Adding support for referrerPolicy in page.goto
#9561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Could you please run |
OrKoN
approved these changes
Jan 23, 2023
Merged
OrKoN
pushed a commit
that referenced
this pull request
Jan 23, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>puppeteer: 19.6.0</summary> ## [19.6.0](puppeteer-v19.5.2...puppeteer-v19.6.0) (2023-01-23) ### Miscellaneous Chores * **puppeteer:** Synchronize puppeteer versions ### Dependencies * The following workspace dependencies were updated * dependencies * puppeteer-core bumped from 19.5.2 to 19.6.0 </details> <details><summary>puppeteer-core: 19.6.0</summary> ## [19.6.0](puppeteer-core-v19.5.2...puppeteer-core-v19.6.0) (2023-01-23) ### Features * **chromium:** roll to Chromium 110.0.5479.0 (r1083080) ([#9500](#9500)) ([06e816b](06e816b)), closes [#9470](#9470) * **page:** Adding support for referrerPolicy in `page.goto` ([#9561](#9561)) ([e3d69ec](e3d69ec)) ### Bug Fixes * firefox revision resolution should not update chrome revision ([#9507](#9507)) ([f59bbf4](f59bbf4)), closes [#9461](#9461) * improve screenshot method types ([#9529](#9529)) ([6847f88](6847f88)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9394
What kind of change does this PR introduce?
Feature - Added support of the
referrerPolicyparameter (from CDP'sPage.navigate) to Puppeteer'spage.goto.Did you add tests for your changes?
No, currently it has no meaning that isn't browser implementation based, which might get broken in the future. If there are suggestions to tests, please let me know so I'll add them.
If relevant, did you update the documentation?
Yes, the documentation of the
gotomethod has been updated.Summary
I wanted to contribute to this project, which I used for testing on our environment and saw issue #9394, so I decided to resolve it :)
Does this PR introduce a breaking change?
No. I added the
referrerPolicyas an optional parameter, which will use the HTTP headerReferrer-Policyif not provided (much like therefererparameter) so it will not interfere.