feat!: add abort function to Runner and remove stepIdx parameter from run method
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should run |
|
I think we probably should, WDYT? |
ergunsh
force-pushed
the
abort-execution
branch
2 times, most recently
from
75e252b
to
9562137
Compare
|
I agree since we expect that to be used for cleaning up, after aborting users probably will need to clean up too. |
OrKoN
reviewed
Jun 9, 2022
OrKoN
approved these changes
Jun 9, 2022
|
let's add "BREAKING CHANGE: " to the final commit message though |
ergunsh
changed the title
abort function to Runnerabort function to Runner and remove stepIdx parameter from run method
ergunsh
changed the title
abort function to Runner and remove stepIdx parameter from run methodabort function to Runner and remove stepIdx parameter from run method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
abortfunction that stops running the remaining steps.