Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run all recording files in directory with cli #184

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

puskuruk
Copy link
Contributor

@puskuruk puskuruk commented Jun 10, 2022

Implements #183

  • Tests pass
  • Appropriate changes to README are included in PR

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 20, 2022

Hey, thanks for the PR. It looks like some tests are failing. Also I have been wondering if the shell filename expansion would work? Basically, the following already works in shells:

npx @puppeteer/replay replay*
Running replay.json...
Finished running replay.json
Running replay2.json...
Finished running replay2.json

@puskuruk puskuruk force-pushed the run-folder-of-recordings branch 2 times, most recently from bbf54e8 to b780531 Compare June 21, 2022 19:27
@puskuruk
Copy link
Contributor Author

Thank you for the feedback @OrKoN. I updated the PR and now all the tests pass. 💃

Yes, shell filename expansion works. But when you want to run a folder with different files(like we have in /test/resources) you should give the extension as well.

npx @puppeteer/replay replay/*.json

With my pr it's easier. You just need to run the command below. It'll only run JSON files in the folder. 

npx @puppeteer/replay replay

If you think using shell filename expansion is a better approach, we should update the README. 🙏

@puskuruk
Copy link
Contributor Author

I saw the problem with Windows paths and I fixed it 🙏

@OrKoN
Copy link
Collaborator

OrKoN commented Jun 22, 2022

Sounds good, could you please update the README with this? I think the code looks good.

@puskuruk
Copy link
Contributor Author

Thank you @OrKoN !

I updated the README with this. You can check the last commit 🙏

@OrKoN OrKoN enabled auto-merge (squash) June 22, 2022 13:28
auto-merge was automatically disabled June 22, 2022 13:39

Head branch was pushed to by a user without write access

@puskuruk
Copy link
Contributor Author

There was a code style issue on README and I fixed it. Can you run GH actions again? @OrKoN

@OrKoN OrKoN enabled auto-merge (squash) June 22, 2022 13:42
@OrKoN OrKoN merged commit 5261098 into puppeteer:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants