fix: close browser after run and throw errors #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergunsh
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
OrKoN
reviewed
Jun 29, 2022
ergunsh
force-pushed
the
close-browser-after-cli-run
branch
2 times, most recently
from
689707e
to
a386259
Compare
OrKoN
approved these changes
Jun 29, 2022
ergunsh
force-pushed
the
close-browser-after-cli-run
branch
from
a386259
to
0596787
Compare
* We need to close the browser so that process exits at the end of the runs * We need to throw the error so that process exits with exit code 1 when the replay was not successful
ergunsh
force-pushed
the
close-browser-after-cli-run
branch
from
0596787
to
369c823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with using
@puppeteer/replaylibrary in CI and these two issues need to be fixed for it to be useful in those contexts.exits at the end of the runs
exits with exit code 1 when the replay
was not successful