feat: sync various improvements #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
improve-runner
branch
from
94d0ac9
to
2faf4f2
Compare
OrKoN
force-pushed
the
improve-runner
branch
from
2faf4f2
to
892cd9a
Compare
jrandolf-zz
approved these changes
Feb 21, 2022
jrandolf-zz
reviewed
Feb 21, 2022
| (el: Element, newValue: string) => { | ||
| /* c8 ignore next 10 */ | ||
| const input = el as HTMLInputElement; | ||
| if ( |
There was a problem hiding this comment.
Could we invert this so the shorter code comes first?
| @@ -41,13 +41,16 @@ export class PuppeteerRunnerExtension extends RunnerExtension { | |||
|
|
|||
| const targetPage = await getTargetPageForStep(browser, page, step, timeout); | |||
| let targetFrame: Frame | null = null; | |||
| if (!targetPage) { | |||
| if (!targetPage && step.target) { | |||
| const frames = page.frames(); | |||
| for (const f of frames) { | |||
| if (f.isOOPFrame() && f.url() === step.target) { | |||
| targetFrame = f; | |||
There was a problem hiding this comment.
Should we break after the first frame found?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.