Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PuppeteerReplayStringifyExtension #381

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Nov 16, 2022

This PR adds a possibility to convert a user flow into a JS script that makes use of the replay's lib own APIs to execute the flow. It adds a method to LineWrite to get the current indent and modifies the appendLine to allow for multiline input that could be formatted better.

@OrKoN OrKoN force-pushed the feat-replay-stringify branch 2 times, most recently from 5b7dc8e to 02e8440 Compare November 16, 2022 10:12
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor comments, but LGTM.

src/InMemoryLineWriter.ts Outdated Show resolved Hide resolved
src/InMemoryLineWriter.ts Outdated Show resolved Hide resolved
OrKoN and others added 2 commits November 16, 2022 11:47
Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>
@OrKoN OrKoN enabled auto-merge (squash) November 16, 2022 10:47
@OrKoN OrKoN merged commit f1abc72 into main Nov 16, 2022
@OrKoN OrKoN deleted the feat-replay-stringify branch November 16, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants