Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support typescript commonjs modules using moduleresolution nodenext #401

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

thovden
Copy link
Contributor

@thovden thovden commented Dec 6, 2022

Fixes #400

It's a good idea to open an issue first for discussion.

  • [ x ] Tests pass
  • [ x ] Appropriate changes to README are included in PR

@google-cla
Copy link

google-cla bot commented Dec 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@thovden thovden changed the title Fix/module resolution cjs fix: support typescript commonjs modules using moduleresolution nodenext Dec 6, 2022
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OrKoN OrKoN merged commit 67c5b23 into puppeteer:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript CommonJS replay clients are broken when using moduleResolution nodenext
2 participants