feat: add visible, properties, and attributes to waitForElement
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Dec 16, 2022
OrKoN
reviewed
Dec 16, 2022
OrKoN
requested changes
Dec 16, 2022
jrandolf
changed the title
hidden, properties, and attributes to waitForElementvisible, properties, and attributes to waitForElement
jrandolf
force-pushed
the
assertion
branch
3 times, most recently
from
1e8ecdc
to
9983e5c
Compare
OrKoN
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new properties:
attributes- This is a dictionary of strings that will match attributes of an element. This will always be a partial match.For example,
”attributes”: {“value”: “125”}.properties- This is a JS record of JSON-serializable attributes that can be used to match an element’s JSON-serializable properties. This will be a sub-tree exact match. For arrays, order matters.visible- This is a boolean value that inverts the match criteria.