Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CLI to test extension implementations #435

Merged
merged 2 commits into from
Jan 24, 2023
Merged

feat: CLI to test extension implementations #435

merged 2 commits into from
Jan 24, 2023

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jan 23, 2023

This PR renames the benchmark test to the "spec" test and adds a new CLI command that allows running the spec test against any stringify or runner extension:

npx -p @puppeteer/replay replay-extension-test --ext path-to-your-extension-js

Closes #275

I moved the spec test content into a JS file because I could not find good rollup plugins to bundle test resources with the CLI.

@OrKoN OrKoN force-pushed the orkon/test-spec branch 3 times, most recently from 3a2bed9 to f6c1a02 Compare January 23, 2023 16:45
@OrKoN OrKoN changed the title feat: cli to test extension implementations feat: CLI to test extension implementations Jan 23, 2023
@OrKoN OrKoN marked this pull request as ready for review January 24, 2023 09:08
Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with 1 comment.

src/extension-test.ts Outdated Show resolved Hide resolved
src/extension-test.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve e2e test coverage for stringified scripts
2 participants