feat: use locators in Puppeteer extensions #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/locators
branch
2 times, most recently
from
de62ffb
to
695c9ae
Compare
OrKoN
force-pushed
the
orkon/locators
branch
3 times, most recently
from
244da8d
to
94845f9
Compare
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/locators
branch
2 times, most recently
from
6e934fc
to
a4ad4a2
Compare
jrandolf
approved these changes
Jul 4, 2023
OrKoN
pushed a commit
that referenced
this pull request
Jul 4, 2023
🤖 I have created a release *beep* *boop* --- ## [2.12.0](v2.11.2...v2.12.0) (2023-07-04) ### Features * use locators in Puppeteer extensions ([#569](#569)) ([92d7666](92d7666)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the PuppeteerRunner and PuppeteerStringify extensions to use the new Locator API which makes several helpers redundant and make the replay more reliable.