Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I am not suggesting an implementation, I am suggesting an API surface. #648

Closed
thicha10 opened this issue Aug 25, 2023 · 0 comments
Closed

I am not suggesting an implementation, I am suggesting an API surface. #648

thicha10 opened this issue Aug 25, 2023 · 0 comments

Comments

@thicha10
Copy link 

          I am not suggesting an implementation, I am suggesting an API surface.

When I do const runner = await createRunner(recording);, I do not have to pass any browser or page, this is why I do not expect to provide browser or page when I want to extend createRunner via a PuppeteerRunnerExtension

Could the extension get its browser and page from the one used by createRunner if not provided?

Originally posted by @steren in #201 (comment)
@OrKoN OrKoN closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OrKoN @thicha10