Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules with long file paths can be published but not installed #144

Closed
michaeltlombardi opened this issue Apr 16, 2021 · 3 comments
Closed
Labels
bug Something isn't working
Projects

Comments

@michaeltlombardi
Copy link

Describe the Bug

Using the functions in this module, it is possible to puppetize and publish a module with DSC Resources which cannot be installed via puppet module install.

Expected Behavior

Modules published to the forge can be installed by end users.

Steps to Reproduce

# Validate the module is buildable
New-Item /tdsc -ItemType Directory
Import-Module -Name Puppet.Dsc
New-PuppetDscModule New-PuppetDscModule -PowerShellModuleName xremotedesktopsessionhost -Verbose -OutputDirectory /tdsc
# Show that the module built in this way is _not_ installable
puppet module install dsc-xremotedesktopsessionhost --version 2.0.0-0-1 --trace

Additional Context

The root of this problem is with minitar as described in PUP-10924 and elaborated on in PDK-1684 - as long as we are unable to support long paths on module installation even when the operating system supports those paths we will have modules which are not installable by end users.

This Issue needs to be resolved before a 1.0.0 release can be cut.

@michaeltlombardi michaeltlombardi added the bug Something isn't working label Apr 16, 2021
@michaeltlombardi michaeltlombardi added this to the 002: End to End Testing milestone Apr 16, 2021
@michaeltlombardi michaeltlombardi added this to To do in DSC via automation Apr 16, 2021
@michaeltlombardi
Copy link
Author

Support for long file paths has landed in core ruby but not yet in minitar.

@michaeltlombardi michaeltlombardi removed this from the 002: End to End Testing & 1.0.0 Release milestone Jun 14, 2021
@michaeltlombardi
Copy link
Author

Possibly resolved by #169 once testing and docs are implemented

DSC automation moved this from To do to Done Jul 13, 2021
@michaeltlombardi
Copy link
Author

No longer able to reproduce the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
DSC
Done
Development

No branches or pull requests

1 participant