Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deprecated setting in devcontainer.json #456

Closed
deric4 opened this issue Oct 1, 2021 · 0 comments
Closed

update deprecated setting in devcontainer.json #456

deric4 opened this issue Oct 1, 2021 · 0 comments

Comments

@deric4
Copy link

deric4 commented Oct 1, 2021

Use Case

the default shell setting in devcontainer.json is now deprecated:

"settings": {
"terminal.integrated.shell.linux": "/bin/bash"
},

devcontainer-warning

Describe the Solution You Would Like

update the template to something like:

     //...
     "settings": {
          "terminal.integrated.defaultProfile.linux": "bash"
      },
     //...	

Describe Alternatives You've Considered

Completely ignoring the template

Additional Context

Working on applying templates across many modules and would like to standardized the devcontainer configuration. Unfortunately I've been running into quite a few problems but this was seemed trivial enough to request changes upstream 😄

Additionally, I'm unsure if changes here make sense or should or if https://github.com/puppetlabs/pdkgo would be better suited.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants