Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When honeycomb is disabled command buildevents is not known, but still used in github actions scripts #477

Closed
cmhe opened this issue Aug 2, 2022 · 1 comment
Labels

Comments

@cmhe
Copy link

cmhe commented Aug 2, 2022

Describe the Bug

When honeycomb is disabled the github actions templates still generated scripts using the buildevents command, which is not known in that case.

Expected Behavior

When honeycomb is disabled, the buildevents command is not used in any github actions script.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Disable honeycomb in .sync.yml, regenerated/update template (version 2.5.0)
  2. grep .github/workflows/pr_test.yml.erb for buildevents and see that it is still there
  3. running it with github actions, will cause a command not found error

Environment

  • Version 2.5.0 of the template
@jordanbreen28
Copy link
Contributor

Closing as honeycomb has since been removed from the templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants