Add new control command for creating control repository

[bittner]

PDK should support creating and extending a control-repository, which is enabled for validation and testing using PDK (just like the modules created by PDK).

Obsoletes #289 and #332 when implemented.
See also: puppetlabs/control-repo#52

Proposed Solution

Ideally,

• the validation and test setup currently present in generated modules should be taken over to the proposed Puppet Labs control-repo, and
• the pdk new control command should generate a control-repo setup that is equivalent to the proposed Puppet Labs control-repo on GitHub.

This way, whether you use PDK or just the GitHub repo as an example, you can trust to get a usable best-practice setup.

[cdenneen]

@bittner except for the metadata.json check the validation will work on existing control repo so far that I can tell.
The ability to generate a control repo would definitely need to be added and skip the metadata.json check in those cases.

[bittner]

The Gemfile is needed to make pdk validate work on a control repo, see #289 (comment).

The Rakefile, .fixtures.yml (with links: to the roles and profiles folders, and more dependencies specified in the forge_modules: section), spec/spec_helper.rb and specs in spec/classes/ is needed for pdk test unit.

Not sure how the examples/ would come into play. Then there are also acceptance tests (as seen in the PSICK repo). If that all makes sense it must be generated, and work out of the box. 👍

[ardrigh]

I was talking with my team about adopting PDK, and the files PDK adds when it converts modules, so that it can run the tests and validation.

Currently our control repo has 40+ internal Puppet modules, and converting them all with PDK would potentially add a huge number of duplicate files (Gemfile etc).

It would be good to know if support for testing across control repos is still on the development plan.

I am hopeful we will eventually be able migrate our TravisCI setup to test our control repo solely using simple PDK commands

[ardrigh]

Additional question, has any thought been given to integrating the onceover gem into PDK for control repo testing?

[Nekototori]

I'd second onceover. PDK is to modules as onceover is to control repos (as it stands today).

[scotje]

This issue was moved to puppetlabs/pdk-planning#10