-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for module level Hiera data #424
Labels
JIRA
JIRA Ticket Created
Comments
Should be implemented in conjunction with #246. |
I totally overlooked that the |
Thanks @ardrigh , https://tickets.puppetlabs.com/browse/PDK-908 was created to track this feature request. |
This issue was moved to puppetlabs/pdk-planning#12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just tested PDK 1.3.2 to create a new module, and I noticed it doesn't add support for module level hiera data.
This is probably seen as a compatibility issue, since it's only supported with Puppet 4.9+ and PDK defaults to Puppet 4.7
A nice way to add this would be an additional question asking if the module level Hiera data support is wanted (not asking if "required"). Then set version based on a Yes/No answer given by the user.
Alternatively, a question could be added about supported Puppet versions. It could list 4.7.0 with global Hiera data, or > 4.9.0 with module level Hiera data support. Perhaps output a docs URL for people to find information, or include the docs URL in the
help
information.Based off the choice made by the user, PDK could then create the
data
directory and updatemetadata.json
with the"data_provider": "hiera"
line.Edit: Also create a basic
hiera.yaml
pointing to a stubdata/common.yaml
This might be a good way to get more modules using this feature, and exposing Puppet module developers to the benefits it can provide.
The text was updated successfully, but these errors were encountered: