json written as .yaml file for code-manager config

[bastelfreak]

Describe the Bug

code-manager uses a r10k.yaml at /opt/puppetlabs/server/data/code-manager/r10k.yaml. Three issues:

• The content is json, not yaml (yes json is a yaml subset, but still this looks wrong)
• It's a single line and not properly formatted, which makes it incredible hard to read
• There is no \n at the end which breaks the prompt in the terminal:

# file /opt/puppetlabs/server/data/code-manager/r10k.yaml
/opt/puppetlabs/server/data/code-manager/r10k.yaml: ASCII text, with very long lines, with no line terminators
[root@pe ~]# cat /opt/puppetlabs/server/data/code-manager/r10k.yaml
{"sources":{"puppet":{"remote":"git@github.com:bastelfreak/controlrepo.git","basedir":"/etc/puppetlabs/code-staging/environments","invalid_branches":"error"}},"cachedir":"/opt/puppetlabs/server/data/code-manager/git","forge":{"baseurl":"https://forgeapi.puppetlabs.com"},"git":{"private_key":"/etc/puppetlabs/puppetserver/ssh/ed25519","repositories":[],"provider":"shellgit"},"deploy":{"purge_levels":["deployment","environment","puppetfile"],"purge_allowlist":[".resource_types"],"exclude_spec":true},"pool_size":4}[root@pe ~]#

Also editors tend to automatically add the missing \n.

Expected Behavior

a proper yaml with indentation and final \n at the end. Please use stdlib::to_yaml().

Steps to Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'

Environment

• PE 2021.7.7

Additional Context

Add any other context about the problem here.