Do not add pe.conf data to PE node group

[bastelfreak]

Use Case

the pe-installer can take a pe.conf from a user. The data will be added to a node group. I think this is bad because there's no easy way to change the data afterwards. I think the least painful way of changing the data would be custom puppet resource types. The data cannot be overwritten by hiera because the PE console has a higher significance. Also it's not intuitive for the user that the data is added to a node group. It's hard to find, not well documented and people don't know that it's hard to change afterwards until they have to change it.

Describe the Solution You Would Like

I think the data from pe.conf should be used on a global hiera level, but it should not be added to a node group. That just adds another layer of complexity and it's hard to clean it up or change it in an automated way. Manipulate or delete local yaml or json files in the hiera level is way way easier.

Describe Alternatives You've Considered

https://github.com/WhatsARanjit/puppet-node_manager can be used to clean up the data. But I think the better solution is to avoid the data in the node groups in the first place.

$group = 'PE Master'
$data = dig(node_groups($group))[$group]
$classes = dig($data, 'classes')
if $classes {
  if dig($classes, 'puppet_enterprise::profile::master', 'r10k_remote') {
    $master = { 'puppet_enterprise::profile::master' => $classes['puppet_enterprise::profile::master'] - 'r10k_remote' }
    $new_classes = $classes + $master
    node_group { $group:
      classes        => $new_classes,
      purge_behavior => 'classes',
      # purge read only attributes + classes
      *              => $data - ['environment_trumps', 'last_edited', 'serial_number', 'config_data', 'id','classes',],
    }
  } else {
    echo {"r10k_remote not set in node group ${group}":
      withpath => false,
    }
  }
} else {
  echo { "no classes hash in node group ${group}":
    withpath => false,
  }
}

Additional Context

This is based on a slack conversation that started at https://puppetcommunity.slack.com/archives/CFD8Z9A4T/p1712265507861729